linux-kernel - Re: [PATCH v2] staging: comedi: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Nov 2017 10:46:36 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Jesse Chan <jc@...ux.com>
Cc:     H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: comedi: add missing
 MODULE_DESCRIPTION/LICENSE

On 20/11/17 10:29, Ian Abbott wrote:
> On 20/11/17 07:50, Jesse Chan wrote:
>> This change resolves a new compile-time warning
>> when built as a loadable module:
>>
>> WARNING: modpost: missing MODULE_LICENSE() in 
>> drivers/staging/comedi/drivers/ni_atmio.o
>> see include/linux/module.h for more information
>>
>> This adds the license as "GPL", which matches the header of the file.
>>
>> MODULE_DESCRIPTION is also added.
>>
>> Signed-off-by: Jesse Chan <jc@...ux.com>
>> ---
>>   drivers/staging/comedi/drivers/ni_atmio.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c 
>> b/drivers/staging/comedi/drivers/ni_atmio.c
>> index 2d62a8c57332..b61d56367773 100644
>> --- a/drivers/staging/comedi/drivers/ni_atmio.c
>> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
>> @@ -361,3 +361,6 @@ static struct comedi_driver ni_atmio_driver = {
>>       .detach        = ni_atmio_detach,
>>   };
>>   module_comedi_driver(ni_atmio_driver);
>> +
>> +MODULE_DESCRIPTION("Comedi low-level driver");
>> +MODULE_LICENSE("GPL");
> 
> Thanks!  I wonder how I managed to miss out this driver in commit 
> 3c323c01b6bd ("Staging: comedi: Add MODULE_LICENSE and similar to NI 
> modules")?
> 
> Reviewed-by: Ian Abbott <abbotti@....co.uk>

Despite my above comment, we should probably give precedence to Matthew 
Giassa's patch for the same issue, since it was sent earlier.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-