linux-kernel - Re: [PATCH] time: Make NTP optionnal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Nov 2017 16:08:53 +0000
From:   Alan Cox <gnomes@...rguk.ukuu.org.uk>
To:     peter enderborg <peter.enderborg@...y.com>
Cc:     Romain Perier <romain.perier@...il.com>,
        John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...eaurora.org>,
        <linux-api@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] time: Make NTP optionnal

On Mon, 20 Nov 2017 16:22:06 +0100
peter enderborg <peter.enderborg@...y.com> wrote:

> On 11/20/2017 04:00 PM, Romain Perier wrote:
> > Hi,
> >
> > 2017-11-20 15:10 GMT+01:00 peter enderborg <peter.enderborg@...y.com>:  
> >> I think it should return a error code at least.  
> > In which case ? The idea was to don't change the behaviour of these
> > functions (from the "API" point of view) and to avoid regressions in
> > the kernel components that depend on these NTP feature.
> > (so be transparent the most as possible)
> >
> > Thanks,
> > Romain
> >  
> 
> do_adjtimex should return -ENOSYS in my opinion, however it is not in the manual
> that it can return ENOSYS. 

The standards specifications state what must be returned for certain
error cases, they don't forbid other errors being added.

Old old Linx will of course already return -1,ENOSYS to this call.

Alan