lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Nov 2017 06:29:46 +0100 From: "H. Nikolaus Schaller" <hns@...delico.com> To: Tony Lindgren <tony@...mide.com> Cc: Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Benoît Cousson <bcousson@...libre.com>, Russell King <linux@...linux.org.uk>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Kevin Hilman <khilman@...libre.com>, Andreas Färber <afaerber@...e.de>, Thierry Reding <treding@...dia.com>, Jonathan Cameron <jic23@...nel.org>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, letux-kernel@...nphoenux.org, kernel@...a-handheld.com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v4 4/5] DTS: gta04: add serdev node for w2sg00x4 Hi Tony, > Am 17.11.2017 um 18:08 schrieb Tony Lindgren <tony@...mide.com>: > > * H. Nikolaus Schaller <hns@...delico.com> [171115 21:41]: >> GTA04 has a W2SG0004/84 connected to UART2 of the OMAP3 >> processor. A GPIO can pulse the on/off toggle switch. >> >> The VSIM regulator is used to power on/off the LNA of an external >> active GPS antenna so that a driver can turn the LNA off if GPS is >> not needed to save battery energy. >> >> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com> >> --- >> arch/arm/boot/dts/omap3-gta04.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi >> index 4504908c23fe..e967d738aaaf 100644 >> --- a/arch/arm/boot/dts/omap3-gta04.dtsi >> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi >> @@ -477,6 +477,12 @@ >> &uart2 { >> pinctrl-names = "default"; >> pinctrl-0 = <&uart2_pins>; >> + >> + gps: gps { >> + compatible = "wi2wi,w2sg0004"; >> + lna-supply = <&vsim>; /* LNA regulator */ >> + enable-gpios = <&gpio5 17 GPIO_ACTIVE_HIGH>; /* GPIO_145: trigger for turning on/off w2sg0004 */ >> + }; >> }; > > How about move the comment above the node to avoid long lines? > Or just change it to gpio_145 for the comment as the property > is already enable-gpios? > > Regards, > > Tony Done so that it will be included in next version. BR and thanks, Nikolaus
Powered by blists - more mailing lists