linux-kernel - Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Nov 2017 16:17:14 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting
 per-thread shadow stats

On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote:
> In current stat-shadow.c, the rblist deleting is ignored.
> 
> The patch reconstructs the codes of rblist init/free, and adds
> the implementation to node_delete method of rblist.
> 
> This patch also does:
> 
> 1. Add the ctx/type/stat into rbtree keys because we will
> use this rbtree to maintain shadow metrics to replace original
> a couple of static arrays for supporting per-thread shadow stats.
> 
> 2. Create a static runtime_stat variable 'rt_stat' which
> will log the shadow metrics by default.

please make that separate patches then,
one patch - one logical change

thanks,
jirka