linux-kernel - Re: [PATCH 2/2] ARM: dts: TS-7970: add basic device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Nov 2017 10:37:39 -0500
From:   Sebastien Bourdelin <sebastien.bourdelin@...oirfairelinux.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        kernel@...oirfairelinux.com,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Mark Rutland <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>, kris@...eddedarm.com,
        Mark Featherston <mark@...eddedarm.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 2/2] ARM: dts: TS-7970: add basic device tree

Hi Fabio,

On 11/20/2017 06:37 PM, Fabio Estevam wrote:
> Hi Sebastien,
> 
> On Mon, Nov 20, 2017 at 7:15 PM, Sebastien Bourdelin
> <sebastien.bourdelin@...oirfairelinux.com> wrote:
> 
>> +&ecspi2 {
>> +       cs-gpios = <
>> +               &gpio5 31 GPIO_ACTIVE_HIGH
>> +               &gpio7 12 GPIO_ACTIVE_HIGH
>> +               &gpio5 18 GPIO_ACTIVE_HIGH
>> +       >;
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_ecspi2>;
>> +       status = "okay";
>> +
>> +       spidevfpga: spi@1 {
>> +               compatible = "spidev";
>> +               reg = <1>;
>> +               spi-max-frequency = <1000000>;
> 
> According to drivers/spi/spidev.c:
> 
> /*
> * spidev should never be referenced in DT without a specific
> * compatible string, it is a Linux implementation thing
> * rather than a description of the hardware.
> */
> 

Thanks, you are right!
Just to point it, this warning has been introduced in
956b200a846e324322f6211034c734c65a38e550 in date of march 2015, and it
seems some devices trees whom had been introduced after still use the
"spidev" string only.