linux-kernel - Re: [PATCH] MIPS: Fix CPS SMP NS16550 UART defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Nov 2017 19:32:05 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     James Hogan <james.hogan@...s.com>,
        Ralf Baechle <ralf@...ux-mips.org>
Cc:     Paul Burton <paul.burton@...tec.com>, linux-kernel@...r.kernel.org,
        James Hogan <jhogan@...nel.org>, linux-mips@...ux-mips.org
Subject: Re: [PATCH] MIPS: Fix CPS SMP NS16550 UART defaults

On 11/20/2017 04:02 PM, James Hogan wrote:
> From: James Hogan <jhogan@...nel.org>
> 
> The MIPS_CPS_NS16550_BASE and MIPS_CPS_NS16550_SHIFT options have no
> defaults for non-Malta platforms which select SYS_SUPPORTS_MIPS_CPS
> (i.e. the pistachio and generic platforms). This is problematic for
> automated allyesconfig and allmodconfig builds based on these platforms,
> since make silentoldconfig tries to ask the user for values, and
> especially since v4.15 where the default platform was switched to
> generic.
> 
> Default these options to 0 and arrange for MIPS_CPS_NS16550 to be no
> when using that default base address, so that the option only has an
> effect when the default is provided (i.e. Malta) or when a value is
> provided by the user.
> 
> Fixes: 609cf6f2291a ("MIPS: CPS: Early debug using an ns16550-compatible UART")
> Signed-off-by: James Hogan <jhogan@...nel.org>
> Reviewed-by: Paul Burton <paul.burton@...s.com>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: linux-mips@...ux-mips.org
> ---
> Guenter: I'm guessing this is the problem you're referring to.

Yes.

Tested-by: Guenter Roeck <linux@...ck-us.net>

mips:allmodconfig still fails to build with this patch applied, but elsewhere.

In file included from /opt/buildbot/slave/hwmon-testing/build/include/linux/bcma/bcma.h:10:0,
                  from /opt/buildbot/slave/hwmon-testing/build/drivers/bcma/bcma_private.h:9,
                  from /opt/buildbot/slave/hwmon-testing/build/drivers/bcma/main.c:8:
/opt/buildbot/slave/hwmon-testing/build/include/linux/bcma/bcma_driver_pci.h:218:24: error: field 'pci_controller' has incomplete type

Guenter