linux-kernel - Re: selftests: Completion of error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Nov 2017 20:30:14 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     shuah@...nel.org, linux-kselftest@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: selftests: Completion of error handling

>> Static source code analysis points out that the checking of return values from
>> some function calls is incomplete also in this software area.
>> How would you like to fix remaining open issues there?
>>
> 
> Without understanding the details on which failures,

Are you using any dedicated tools for this purpose already?

> it would be hard for me comment on how to handle them.

I inspected also another specific source file for example.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/tools/testing/selftests/timers/posix_timers.c?id=aa1fbe633d3034f9f838ff13387af04771e68e31#n81
https://elixir.free-electrons.com/linux/v4.14-rc8/source/tools/testing/selftests/timers/posix_timers.c#L78

This one contains some places (like in the function “check_itimer”)
where the error detection and corresponding exception handling is incomplete
so far.
Other source files can contain similar update candidates.

There are different design options available to improve the software
situation here.
Which development directions do you prefer?

Regards,
Markus