linux-kernel - Re: [PATCH v2] staging: fsl-mc: fix mc-portal to use u32 type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2017 11:21:16 +1100
From:   "Tobin C. Harding" <me@...in.cc>
To:     Bharat Bhushan <Bharat.Bhushan@....com>
Cc:     gregkh@...uxfoundation.org, laurentiu.tudor@....com,
        devel@...verdev.osuosl.org, stuyoder@...il.com, roy.pledge@....com,
        linux-kernel@...r.kernel.org, leoyang.li@....com,
        bogdan.purcareata@....com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] staging: fsl-mc: fix mc-portal to use u32 type

On Tue, Nov 21, 2017 at 10:35:23AM +0530, Bharat Bhushan wrote:
> According to MC APIs, size of mc-portal in 32bit.
> Also fsl_create_mc_io() storing 32 bit mc-portal size.
>    " mc_io->portal_size = mc_portal_size;"
>    While "mc_io->portal_size" is u16 type and
>    "mc_portal_size" is u32 type.
> 
> This patches changes mc_io->portal_size from u16 to u32

You may like to read Documentation/process/submitting-patches.rst for
tips or writing the git commit log.

> Signed-off-by: Bharat Bhushan <Bharat.Bhushan@....com>
> ---

Include here what changed from v1 -> v2

>  drivers/staging/fsl-mc/include/mc-sys.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fsl-mc/include/mc-sys.h b/drivers/staging/fsl-mc/include/mc-sys.h
> index dca7f90..11d4367 100644
> --- a/drivers/staging/fsl-mc/include/mc-sys.h
> +++ b/drivers/staging/fsl-mc/include/mc-sys.h
> @@ -75,7 +75,7 @@
>  struct fsl_mc_io {
>  	struct device *dev;
>  	u16 flags;
> -	u16 portal_size;
> +	u32 portal_size;
>  	phys_addr_t portal_phys_addr;
>  	void __iomem *portal_virt_addr;
>  	struct fsl_mc_device *dpmcp_dev;

I was not able to apply this patch to either Greg's staging tree or
Linus' mainline.

Does this change clear any Sparse warnings? If so you may like to note
that in the commit log.

Hope this helps,
Tobin.