lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 22 Nov 2017 10:20:44 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting
 per-thread shadow stats



On 11/21/2017 11:17 PM, Jiri Olsa wrote:
> On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote:
> 
> SNIP
> 
>>   static int evsel_context(struct perf_evsel *evsel)
>> diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
>> index 61fd2e0..4eb081d 100644
>> --- a/tools/perf/util/stat.h
>> +++ b/tools/perf/util/stat.h
>> @@ -126,6 +126,8 @@ typedef void (*print_metric_t)(void *ctx, const char *color, const char *unit,
>>   			       const char *fmt, double val);
>>   typedef void (*new_line_t )(void *ctx);
>>   
>> +void perf_stat__init_runtime_stat(struct runtime_stat *stat);
>> +void perf_stat__free_runtime_stat(struct runtime_stat *stat);
> 
> maybe that could be:
>    runtime_stat__init(struct runtime_stat *stat);
>    runtime_stat__free(struct runtime_stat *stat);
> 
> jirka
> 

Sure, I will update according to your suggestion.

Thanks
Jin Yao

Powered by blists - more mailing lists