linux-kernel - [PATCH 1/1] Add paretheses to macro parameters. For trivial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2017 15:11:53 +0200
From:   Igor Stoppa <igor.stoppa@...wei.com>
To:     <trivial@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        Guenter Roeck <linux@...ck-us.net>,
        Javi Merino <javi.merino@....com>,
        Igor Stoppa <igor.stoppa@...wei.com>
Subject: [PATCH 1/1] Add paretheses to macro parameters. For trivial

kernel.h: Some macros are not wrapping their parameters with parentheses.

Signed-off-by: Igor Stoppa <igor.stoppa@...wei.com>
Cc: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc: Guenter Roeck <linux@...ck-us.net>
Cc: Javi Merino <javi.merino@....com>
---
 include/linux/kernel.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 4b484ab..4061f46 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -112,7 +112,7 @@
 /* The `const' in roundup() prevents gcc-3.3 from calling __divdi3 */
 #define roundup(x, y) (					\
 {							\
-	const typeof(y) __y = y;			\
+	const typeof(y) __y = (y);			\
 	(((x) + (__y - 1)) / __y) * __y;		\
 }							\
 )
@@ -131,8 +131,8 @@
  */
 #define DIV_ROUND_CLOSEST(x, divisor)(			\
 {							\
-	typeof(x) __x = x;				\
-	typeof(divisor) __d = divisor;			\
+	typeof(x) __x = (x);				\
+	typeof(divisor) __d = (divisor);		\
 	(((typeof(x))-1) > 0 ||				\
 	 ((typeof(divisor))-1) > 0 ||			\
 	 (((__x) > 0) == ((__d) > 0))) ?		\
@@ -146,7 +146,7 @@
  */
 #define DIV_ROUND_CLOSEST_ULL(x, divisor)(		\
 {							\
-	typeof(divisor) __d = divisor;			\
+	typeof(divisor) __d = (divisor);		\
 	unsigned long long _tmp = (x) + (__d) / 2;	\
 	do_div(_tmp, __d);				\
 	_tmp;						\
-- 
2.9.3