linux-kernel - Re: [PATCH] mm: Use vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2017 17:32:34 +0200
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     dledford@...hat.com, dave@...olabs.net, jglisse@...hat.com,
        peterz@...radead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Use vma_pages helper

On Wed, Nov 22, 2017 at 04:26:50PM +0100, Vasyl Gomonovych wrote:
> Use vma_pages function on vma object instead of explicit computation.
> mm/interval_tree.c:21:27-33: WARNING: Consider using vma_pages helper
> Generated by: scripts/coccinelle/api/vma_pages.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>


Acked-by: Michael S. Tsirkin <mst@...hat.com>

> ---
>  mm/interval_tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/interval_tree.c b/mm/interval_tree.c
> index b47664358796..27ddfd29112a 100644
> --- a/mm/interval_tree.c
> +++ b/mm/interval_tree.c
> @@ -18,7 +18,7 @@ static inline unsigned long vma_start_pgoff(struct vm_area_struct *v)
>  
>  static inline unsigned long vma_last_pgoff(struct vm_area_struct *v)
>  {
> -	return v->vm_pgoff + ((v->vm_end - v->vm_start) >> PAGE_SHIFT) - 1;
> +	return v->vm_pgoff + vma_pages(v) - 1;
>  }
>  
>  INTERVAL_TREE_DEFINE(struct vm_area_struct, shared.rb,
> -- 
> 1.9.1