linux-kernel - Re: [PATCH] move libgcc.h to include/linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2017 08:50:25 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     hch@....de
CC:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject:     Re: [PATCH] move libgcc.h to include/linux

On Wed, 22 Nov 2017 02:47:28 PST (-0800), hch@....de wrote:
> Introducing a new include/lib directory just for this file totally
> messes up tab completion for include/linux, which is highly annoying.

Sorry about that.

> Move it to include/linux where we have headers for all kinds of other
> lib/ code as well.

That looks good to me.  I'm kind of new to this, do you want me to take this 
into my tree?

Reviewed-by: Palmer Dabbelt <palmer@...ive.com>

>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  include/{lib => linux}/libgcc.h | 0
>  lib/ashldi3.c                   | 2 +-
>  lib/ashrdi3.c                   | 2 +-
>  lib/cmpdi2.c                    | 2 +-
>  lib/lshrdi3.c                   | 2 +-
>  lib/muldi3.c                    | 2 +-
>  lib/ucmpdi2.c                   | 2 +-
>  7 files changed, 6 insertions(+), 6 deletions(-)
>  rename include/{lib => linux}/libgcc.h (100%)
>
> diff --git a/include/lib/libgcc.h b/include/linux/libgcc.h
> similarity index 100%
> rename from include/lib/libgcc.h
> rename to include/linux/libgcc.h
> diff --git a/lib/ashldi3.c b/lib/ashldi3.c
> index 1b6087db95a5..3ffc46e3bb6c 100644
> --- a/lib/ashldi3.c
> +++ b/lib/ashldi3.c
> @@ -16,7 +16,7 @@
>
>  #include <linux/export.h>
>
> -#include <lib/libgcc.h>
> +#include <linux/libgcc.h>
>
>  long long notrace __ashldi3(long long u, word_type b)
>  {
> diff --git a/lib/ashrdi3.c b/lib/ashrdi3.c
> index 2e67c97ac65a..ea054550f0e8 100644
> --- a/lib/ashrdi3.c
> +++ b/lib/ashrdi3.c
> @@ -16,7 +16,7 @@
>
>  #include <linux/export.h>
>
> -#include <lib/libgcc.h>
> +#include <linux/libgcc.h>
>
>  long long notrace __ashrdi3(long long u, word_type b)
>  {
> diff --git a/lib/cmpdi2.c b/lib/cmpdi2.c
> index 6d7ebf6c2b86..2250da7e503e 100644
> --- a/lib/cmpdi2.c
> +++ b/lib/cmpdi2.c
> @@ -16,7 +16,7 @@
>
>  #include <linux/export.h>
>
> -#include <lib/libgcc.h>
> +#include <linux/libgcc.h>
>
>  word_type notrace __cmpdi2(long long a, long long b)
>  {
> diff --git a/lib/lshrdi3.c b/lib/lshrdi3.c
> index 8e845f4bb65f..99cfa5721f2d 100644
> --- a/lib/lshrdi3.c
> +++ b/lib/lshrdi3.c
> @@ -17,7 +17,7 @@
>   */
>
>  #include <linux/module.h>
> -#include <lib/libgcc.h>
> +#include <linux/libgcc.h>
>
>  long long notrace __lshrdi3(long long u, word_type b)
>  {
> diff --git a/lib/muldi3.c b/lib/muldi3.c
> index 88938543e10a..54c8b3123376 100644
> --- a/lib/muldi3.c
> +++ b/lib/muldi3.c
> @@ -15,7 +15,7 @@
>   */
>
>  #include <linux/export.h>
> -#include <lib/libgcc.h>
> +#include <linux/libgcc.h>
>
>  #define W_TYPE_SIZE 32
>
> diff --git a/lib/ucmpdi2.c b/lib/ucmpdi2.c
> index 49a53505c8e3..25ca2d4c1e19 100644
> --- a/lib/ucmpdi2.c
> +++ b/lib/ucmpdi2.c
> @@ -15,7 +15,7 @@
>   */
>
>  #include <linux/module.h>
> -#include <lib/libgcc.h>
> +#include <linux/libgcc.h>
>
>  word_type __ucmpdi2(unsigned long long a, unsigned long long b)
>  {