linux-kernel - [PATCH 53/62] irq: Remove call to idr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2017 13:07:30 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     Matthew Wilcox <mawilcox@...rosoft.com>
Subject: [PATCH 53/62] irq: Remove call to idr_preload

From: Matthew Wilcox <mawilcox@...rosoft.com>

Not entirely clear why the preload was there with no locking.  Maybe at
one time there was a lock, and the preload was never removed?

Signed-off-by: Matthew Wilcox <mawilcox@...rosoft.com>
---
 kernel/irq/timings.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index e0923fa4927a..e9f16527656c 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -356,9 +356,7 @@ int irq_timings_alloc(int irq)
 	if (!s)
 		return -ENOMEM;
 
-	idr_preload(GFP_KERNEL);
-	id = idr_alloc(&irqt_stats, s, irq, irq + 1, GFP_NOWAIT);
-	idr_preload_end();
+	id = idr_alloc(&irqt_stats, s, irq, irq + 1, GFP_KERNEL);
 
 	if (id < 0) {
 		free_percpu(s);
-- 
2.15.0