linux-kernel - Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Nov 2017 13:00:26 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, b.zolnierkie@...sung.com,
        tj@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding
 style error.

On 11/25/2017 7:15 AM, Arvind Yadav wrote:

> Here, The function pdc_hardware_init always return zero. So it is not
> necessary to check its return value.
> 
> Fix these checkpatch.pl error:
> 
> ERROR: space prohibited after that '~' (ctx:WxW)
> +		mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
> 
> ERROR: spaces required around that '?' (ctx:VxW)
> +	long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
> 
> ERROR: that open brace { should be on the previous line
> +	const struct ata_port_info *ppi[] =
> +		{ &pdc2027x_port_info[board_idx], NULL };
> 

    Please fix the checkpatch.pl errors in a sperate patch.

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
[...]

MBR, Sergei