linux-kernel - Re: [PATCH v7,1/2] misc: rtsx: Move Realtek Card Reader Driver to misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 08:10:21 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Perry.Yuan@...l.com
Cc:     rui_feng@...lsil.com.cn, arnd@...db.de, gregkh@...uxfoundation.org,
        ulf.hansson@...aro.org, linux-kernel@...r.kernel.org,
        ricky_wu@...ltek.com, bristot@...hat.com
Subject: Re: [PATCH v7,1/2] misc: rtsx: Move Realtek Card Reader Driver to
 misc

On Tue, 28 Nov 2017, Perry.Yuan@...l.com wrote:
> Hi Greg.
> The Patches have been tested basing on V4.15-rc1 successfully.
> The sdcard function is working well.

Not sure why you're a) top posting, b) doing so with an
incompatible email client and c) sending this to Greg?

There doesn't appear to be a Memstick Maintainer at the moment, which
means we have all of the Maintainer Acks we need (Arnd Acked in Greg's
place for Misc) to apply this patch.

If no one objects, I plan to take this through the MFD tree and
provide everyone else with a pull-request which they can do with as
they see fit.

> Tested-by: Perry Yuan <perry_yuan@...l.com>

Thanks for testing.

> keep up the good work
> Perry  Yuan
> Dell | Client Software Group | Firmware Principal Engineer
> 
> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-owner@...r.kernel.org] On Behalf Of rui_feng@...lsil.com.cn
> Sent: Monday, November 27, 2017 3:35 PM
> To: lee.jones@...aro.org; arnd@...db.de; gregkh@...uxfoundation.org; ulf.hansson@...aro.org
> Cc: linux-kernel@...r.kernel.org; ricky_wu@...ltek.com; bristot@...hat.com; Rui Feng <rui_feng@...lsil.com.cn>
> Subject: [PATCH v7,1/2] misc: rtsx: Move Realtek Card Reader Driver to misc
> 
> From: Rui Feng <rui_feng@...lsil.com.cn>
> 
> Because Realtek card reader drivers are pcie and usb drivers, and
> they bridge mmc subsystem and memstick subsystem, they are not mfd
> drivers. Greg and Lee Jones had a discussion about where to put the
> drivers, the result is that misc is a good place for them, so I move
> all files to misc. If I don't move them to a right place, I can't
> add any patch for this driver.
> 
> Signed-off-by: Rui Feng <rui_feng@...lsil.com.cn>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> Reviewed-by: Daniel Bristot de Oliveira <bristot@...hat.com>
> Acked-by: Ulf Hansson <ulf.hansson@...aro.org>
> 
> v7 changes:
> * update missing modification in memstic
> * add Acked-by
> ---
>  drivers/memstick/host/Kconfig               |  4 ++--
>  drivers/memstick/host/rtsx_pci_ms.c         |  2 +-
>  drivers/memstick/host/rtsx_usb_ms.c         |  2 +-
>  drivers/mfd/Kconfig                         | 21 ---------------------
>  drivers/mfd/Makefile                        |  4 ----
>  drivers/misc/Kconfig                        |  5 +++++
>  drivers/misc/Makefile                       |  1 +
>  drivers/misc/cardreader/Kconfig             | 20 ++++++++++++++++++++
>  drivers/misc/cardreader/Makefile            |  4 ++++
>  drivers/{mfd => misc/cardreader}/rtl8411.c  |  2 +-  drivers/{mfd
> => misc/cardreader}/rts5209.c  |  2 +-  drivers/{mfd =>
> misc/cardreader}/rts5227.c  |  2 +-  drivers/{mfd =>
> misc/cardreader}/rts5229.c  |  2 +-  drivers/{mfd =>
> misc/cardreader}/rts5249.c  |  3 +--  drivers/{mfd =>
> misc/cardreader}/rtsx_pcr.c |  2 +-  drivers/{mfd =>
> misc/cardreader}/rtsx_pcr.h |  2 +-  drivers/{mfd =>
> misc/cardreader}/rtsx_usb.c |  2 +-
>  drivers/mmc/host/Kconfig                    |  4 ++--
>  drivers/mmc/host/rtsx_pci_sdmmc.c           |  2 +-
>  drivers/mmc/host/rtsx_usb_sdmmc.c           |  2 +-
>  include/linux/{mfd => }/rtsx_common.h       |  0
>  include/linux/{mfd => }/rtsx_pci.h          |  2 +-
>  include/linux/{mfd => }/rtsx_usb.h          |  0
>  23 files changed, 47 insertions(+), 43 deletions(-)  create mode
> 100644 drivers/misc/cardreader/Kconfig  create mode 100644
> drivers/misc/cardreader/Makefile  rename drivers/{mfd =>
> misc/cardreader}/rtl8411.c (99%)  rename drivers/{mfd =>
> misc/cardreader}/rts5209.c (99%)  rename drivers/{mfd =>
> misc/cardreader}/rts5227.c (99%)  rename drivers/{mfd =>
> misc/cardreader}/rts5229.c (99%)  rename drivers/{mfd =>
> misc/cardreader}/rts5249.c (99%)  rename drivers/{mfd =>
> misc/cardreader}/rtsx_pcr.c (99%)  rename drivers/{mfd =>
> misc/cardreader}/rtsx_pcr.h (99%)  rename drivers/{mfd =>
> misc/cardreader}/rtsx_usb.c (99%)  rename include/linux/{mfd =>
> }/rtsx_common.h (100%)  rename include/linux/{mfd => }/rtsx_pci.h
> (99%)  rename include/linux/{mfd => }/rtsx_usb.h (100%)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog