linux-kernel - Re: [RFC PATCH v2 1/7] ASoC: Intel: Fix Kconfig with top-level selector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Nov 2017 08:52:58 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     alsa-devel@...a-project.org, tiwai@...e.de, broonie@...nel.org,
        torvalds@...ux-foundation.org, liam.r.girdwood@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, arnd@...db.de,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/7] ASoC: Intel: Fix Kconfig with top-level
 selector

On 11/29/17 4:27 AM, Vinod Koul wrote:
> On Tue, Nov 28, 2017 at 07:45:45PM -0600, Pierre-Louis Bossart wrote:
> 
> I am not sure about top level being default to Y...

It's standard procedure apparently, see Linus/Mark/Takashi's emails.

> 
>>   config SND_SST_ATOM_HIFI2_PLATFORM
>>   	tristate "Intel ASoC SST driver for HiFi2 platforms (*field, *trail)"
>> -	depends on SND_SOC_INTEL_SST_TOPLEVEL && X86
>> +	depends on X86
>>   	select SND_SOC_COMPRESS
>> +	select SND_SOC_INTEL_COMMON
>>   
>>   config SND_SOC_INTEL_SKYLAKE
>>   	tristate "Intel ASoC SST driver for SKL/BXT/KBL/GLK/CNL"
>> -	depends on SND_SOC_INTEL_SST_TOPLEVEL && PCI && ACPI
>> +	depends on PCI && ACPI
>>   	select SND_HDA_EXT_CORE
>>   	select SND_HDA_DSP_LOADER
>>   	select SND_SOC_TOPOLOGY
>>   	select SND_SOC_INTEL_SST
>> +	select SND_SOC_INTEL_COMMON
>> +	help
>> +	  If you have a Intel Skylake/Broxton/ApolloLake/KabyLake/
>> +	  GeminiLake or CannonLake platform with the DSP enabled in the BIOS
>> +	  then enable this option by saying Y or m.
> 
> this is good stuff, helps in improving UX vastly. Btw can we have select ALL
> machine also as an option for people who dont want to select a specfic one,
> that one will really help for a better UX

no, we shouldn't select things, especially with the Baytrail legacy 
which is kept to avoid breaking existing setups but shouldn't be used 
any longer.
And with SOF coming, we may have hybrid configurations with SOF used on 
Baytrail/Cherrytrail/APL/CNL but SST used on Skylake/Kabylake due to 
firmware authentication stuff.

> 
>> +
>> +endif ## SND_SOC_INTEL_SST_TOPLEVEL
>>   
>>   # ASoC codec drivers
>>   source "sound/soc/intel/boards/Kconfig"
>> +
>> +# configs common to SST and SOF to compile sound/soc/intel/common
>> +# directory and use matching tables
>> +
>> +config SND_SOC_INTEL_COMMON
>> +	tristate
>> +	select SND_SOC_ACPI_INTEL_MATCH if ACPI
> 
> common selects only MATCH

COMMON is only there to go compile the sound/soc/intel/common directory. 
That's not very useful indeed but otherwise the Makefile doesn't compile 
the match tables or the sst-ipc stuff. If you find a better solution I 
am all ears.

> 
>> +	# this option controls the compilation of the sound/soc/intel/common
>> +	# directory and is not meant to be selected by the user. It is
>> +	# not filtered out on purpose by the top-level selector since
>> +	# it will be selected by SST or SOF platform driver options
>> +
>> +config SND_SOC_ACPI_INTEL_MATCH
>> +	tristate
>> +	select SND_SOC_ACPI if ACPI
> 
> then why keep common, lets remove one level and have
> SND_SOC_ACPI_INTEL_MATCH selected. ACPI is must have at top level so we can
> add depends on that symbol

we still have platforms which don't depend on ACPI, so we shouldn't take 
this out.