linux-kernel - Re: [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Dec 2017 16:09:28 +0000
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Marcus Wolf <marcus.wolf@...rthome-wolf.de>
Cc:     Marcus Wolf <linux@...f-entwicklungen.de>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        dan.carpenter@...cle.com
Subject: Re: [PATCH] staging: pi433: Removed some obsolete or duplicated
 defines; moved two defines to better locations

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sat, Dec 02, 2017 at 06:00:28PM +0200, Marcus Wolf wrote:
> Hi Greg,
> 
> for me the action was "clean up the defines in rf69.c". So for me it was
> fine, that two defines were moved and several other deleted at the same.
> 
> Is it ok for you, or should I split the patch belated?

Please split it up, and make a patch series.  Don't dribble patches out
over many hours as that just ensures that I will apply them in the wrong
order :(

Take the time, make a patch series, test that they pass the scripts that
we have, and then send them all out at once.

thanks,

greg k-h