linux-kernel - Re: [PATCH] checkpatch: warn for use of %px

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Dec 2017 07:27:21 +1100
From:   "Tobin C. Harding" <me@...in.cc>
To:     Joe Perches <joe@...ches.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Whitcroft <apw@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: warn for use of %px

On Tue, Dec 05, 2017 at 07:27:18AM -0800, Joe Perches wrote:
> On Tue, 2017-12-05 at 20:44 +1100, Tobin C. Harding wrote:
> > On Mon, Dec 04, 2017 at 11:24:24PM -0800, Joe Perches wrote:
> > > On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote:
> > > > Usage of the new %px specifier potentially leaks sensitive
> > > > inforamtion. Printing kernel addresses exposes the kernel layout in
> > > 
> > > information
> 
> > I don't understand this comment? Do you mean the wording is wrong?
> > I'll re-word as suggested below.
> 
> It's just a spelling typo correction.

ha ha, note to self - be careful doing kernel email late at night :)

> []
> > > > Suggested-by: Andrew Morton <akpm@...ux-foundation.org>
> > > > Signed-off-by: Tobin C. Harding <me@...in.cc>
> > > > Co-Developed-by: Joe Perches <joe@...ches.com>
> > > > Are you happy with this tagging? Needs your signed-off-by still.
> 
> I think signatures tags are pretty freeform and
> I'm not particularly concerned about them.
> 
> I think Andrew Morton may object and change it
> or remove it.  Have an:
> 
> Acked-by: Joe Perches <joe@...ches.com>

Cool, will add and re-spin

thanks,
Tobin.