linux-kernel - Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Dec 2017 13:04:46 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Nicolin Chen <nicoleotsuka@...il.com>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        alsa-devel@...a-project.org, fabio.estevam@....com, timur@...i.org,
        mail@...iej.szmigiero.name, caleb@...me.org, lgirdwood@...il.com
Subject: Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote:
> struct device is defined in system level header files any way.
> As long as fsl_ssi.h is included after those header files, it
> should be safe to remove this line.

It's better practice to either directly include those headers or have a
forward declaration like this, it means there's no way things can go
wrong.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)