linux-kernel - Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Dec 2017 12:40:30 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Jon Mason <jdmason@...zu.us>
Cc:     linux-ntb <linux-ntb@...glegroups.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <Allen.Hubbe@....com>,
        Kelvin Cao <kelvin.cao@...rosemi.com>
Subject: Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers



On 05/12/17 12:12 PM, Jon Mason wrote:
> It sucks that we don't already have a struct for PCI config space we
> can reuse here.  If you find the time, it would be good to add in the
> future to reduce duplicate code here and in the PCI core.  However,
> this patch is fine without it.

I agree. And believe me I looked for one. I'm not sure if it makes sense 
to add it to general code at this time when I'm the only user.

Logan