linux-kernel - Re: [PATCH v2] drivers:mtd:spi-nor:checkup FSR error bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Dec 2017 21:20:11 +0100
From:   Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>
To:     "Bean Huo (beanhuo)" <beanhuo@...ron.com>
Cc:     "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drivers:mtd:spi-nor:checkup FSR error bits

Le 04/12/2017 à 14:27, Bean Huo (beanhuo) a écrit :
> Hi, Cyrille
> 
>> Hi Bean,
>>
>> Le 04/12/2017 à 13:34, Bean Huo (beanhuo) a écrit :
>>> For Micron spi nor device, when erase/program operation fails,
>>> especially the failure results from intending to modify protected
>>> space, spi-nor upper layers still get the return which shows the
>>> operation succeeds. This is because current spi_nor_fsr_ready() only
>>> uses FSR bit.7 (flag status register) to check device whether ready.
>>> This patch fixs this issue by checking relevant error
>>
>> s/fixs/fixes/
>>
>>> bits in FSR.
>>> The FSR is a powerful tool to investigate the staus of
>>
>> s/staus/status/
>>
>>> device, checking information regarding what is actually doing the
>>> memory and detecting possible error conditions.
>>>
>>> Signed-off-by: beanhuo <beanhuo@...ron.com>

Applied to the spi-nor/next branch of l2-mtd after correcting few typos
in the commit message and the subject line.

>>
>> Otherwise,
>> Acked-by: Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>
>>
>> No need to resend, I'll fix these tiny issues myself :)
>>
> 
> Thanks!
> 
> // Bean Huo
>