linux-kernel - Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 06 Dec 2017 12:05:06 -0800
From:   Joe Perches <joe@...ches.com>
To:     Alan Stern <stern@...land.harvard.edu>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-usb@...r.kernel.org, Daniel Drake <drake@...lessm.com>,
        Dmitry Fleytman <dmitry@...nix.com>,
        Eugene Korenevsky <ekorenevsky@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Günter Röck <linux@...ck-us.net>,
        Johan Hovold <johan@...nel.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Peter Chen <peter.chen@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] USB: hub: Delete an error message for a failed memory
 allocation in usb_hub_clear_tt_buffer()

On Wed, 2017-12-06 at 11:45 -0500, Alan Stern wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> > Omit an extra message for a memory allocation failure in this function.

Markus' typical terrible commit message.

> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
[]
> > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
> >        */
> >       clear = kmalloc(sizeof *clear, GFP_ATOMIC);
> >       if (clear == NULL) {
> > -             dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
> >               /* FIXME recover somehow ... RESET_TT? */
> >               return -ENOMEM;
> >       }
> 
> Does the existing memory allocation error message include the 
> &udev->dev device name and driver name?  If it doesn't, there will be 
> no way for the user to tell that the error message is related to the 
> device failure.

No, but the effect is similar.

OOM does a dump_stack() so this function's call tree is shown.