linux-kernel - Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Dec 2017 00:24:34 +0200
From:   Marcus Wolf <marcus.wolf@...rthome-wolf.de>
To:     Simon Sandström <simon@...anor.nu>,
        gregkh@...uxfoundation.org
Cc:     linux@...f-Entwicklungen.de, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h



Am 06.12.2017 um 22:42 schrieb Simon Sandström:
> The enum is now only used for ioctl, so move it pi433_if.h.
> 
> Signed-off-by: Simon Sandström <simon@...anor.nu>
> ---
>   drivers/staging/pi433/pi433_if.h  | 5 +++++
>   drivers/staging/pi433/rf69_enum.h | 5 -----
>   2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> index bcfe29840889..c8697d144e2b 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -37,6 +37,11 @@
>   
>   /*---------------------------------------------------------------------------*/
>   
> +enum option_on_off {
> +	OPTION_OFF,
> +	OPTION_ON
> +};
> +
>   /* IOCTL structs and commands */
>   
>   /**
> diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h
> index b0715b4eb6ac..4e64e38ae4ff 100644
> --- a/drivers/staging/pi433/rf69_enum.h
> +++ b/drivers/staging/pi433/rf69_enum.h
> @@ -18,11 +18,6 @@
>   #ifndef RF69_ENUM_H
>   #define RF69_ENUM_H
>   
> -enum option_on_off {
> -	OPTION_OFF,
> -	OPTION_ON
> -};
> -
>   enum mode {
>   	mode_sleep,
>   	standby,
> 

Hi Simon,

sorry - I have one more question.

Why do you want to get rid of the enum option_on_off in rf69_enum.h. I 
generated that file just to store the enums.

Now we have one enum at an other place...

Regards,
Marcus