lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Dec 2017 19:29:47 +0300 From: Vasily Averin <vvs@...tuozzo.com> To: Arnd Bergmann <arnd@...db.de>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, Florian Westphal <fw@...len.de>, "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org> Cc: Xin Long <lucien.xin@...il.com>, netfilter-devel@...r.kernel.org, coreteam@...filter.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] netfilter: fix clusterip_net_exit build regression thank you, it was mu fault. Reviewed-by: Vasily Averin <vvs@...tuozzo.com> On 2017-12-07 16:26, Arnd Bergmann wrote: > The added check produces a build error when CONFIG_PROC_FS is > disabled: > > net/ipv4/netfilter/ipt_CLUSTERIP.c: In function 'clusterip_net_exit': > net/ipv4/netfilter/ipt_CLUSTERIP.c:822:28: error: 'cn' undeclared (first use in this function) > > This moves the variable declaration out of the #ifdef to make it > available to the WARN_ON_ONCE(). > > Fixes: 613d0776d3fe ("netfilter: exit_net cleanup check added") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > net/ipv4/netfilter/ipt_CLUSTERIP.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c > index e35b8d074f06..69060e3abe85 100644 > --- a/net/ipv4/netfilter/ipt_CLUSTERIP.c > +++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c > @@ -813,8 +813,8 @@ static int clusterip_net_init(struct net *net) > > static void clusterip_net_exit(struct net *net) > { > -#ifdef CONFIG_PROC_FS > struct clusterip_net *cn = net_generic(net, clusterip_net_id); > +#ifdef CONFIG_PROC_FS > proc_remove(cn->procdir); > cn->procdir = NULL; > #endif >
Powered by blists - more mailing lists