linux-kernel - Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Dec 2017 09:24:26 -0800
From:   Brian Norris <briannorris@...omium.org>
To:     Philippe CORNU <philippe.cornu@...com>
Cc:     Nickey Yang <nickey.yang@...k-chips.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "heiko@...ech.de" <heiko@...ech.de>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>,
        "laurent.pinchart@...asonboard.com" 
        <laurent.pinchart@...asonboard.com>,
        "seanpaul@...omium.org" <seanpaul@...omium.org>,
        "mka@...omium.org" <mka@...omium.org>,
        "hoegsberg@...il.com" <hoegsberg@...il.com>,
        "architt@...eaurora.org" <architt@...eaurora.org>,
        Yannick FERTRE <yannick.fertre@...com>,
        "hl@...k-chips.com" <hl@...k-chips.com>,
        "zyw@...k-chips.com" <zyw@...k-chips.com>,
        "xbl@...k-chips.com" <xbl@...k-chips.com>
Subject: Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

On Thu, Dec 07, 2017 at 11:41:17AM +0000, Philippe CORNU wrote:
> platform_set_drvdata() is still missing in your version.

Ugh...indeed.

> On 12/06/2017 10:39 PM, Brian Norris wrote:
> > On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote:
> >> From: Brian Norris <briannorris@...omium.org>
> >>
> >> Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
> >> parent driver might need to own this. Instead, let's return our
> >> 'dw_mipi_dsi' object and have callers pass that back to us for removal.
> >>
> >> Signed-off-by: Brian Norris <briannorris@...omium.org>
> >> Signed-off-by: Nickey Yang <nickey.yang@...k-chips.com>
> >> Link:https://patchwork.kernel.org/patch/10078493/
> >>
> >> ---
> >> Changes
> >>
> >> v4:
> >> - Add From tag,update subject line
> >> - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove"
> >>    in this piece together.
> >>
> >> v5:
> >> - remove Review & Ack tag
> >> - fix remove() directly referencing the static
> >>    dw_mipi_dsi_stm_plat_data struct.
> > 
> > You've gotten this back into basically the shape I sent v1 in, so I
> > guess this deserves an:
> > 
> > Acked-by: Brian Norris <briannorris@...omium.org>

...and I even diffed the two directly and didn't notice that one missing
at first :(

So instead, make that:

Nacked-by: Brian Norris <briannorris@...omium.org>

Can you *please* just use my patch and reword the commit message/subject
per the original comments on version 1? You're screwing it up every time
you try to change it...