lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Dec 2017 16:25:42 +1100 From: "Tobin C. Harding" <me@...in.cc> To: Randy Dunlap <rdunlap@...radead.org> Cc: Jonathan Corbet <corbet@....net>, Andrew Murray <amurray@...-data.co.uk>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] doc: convert printk-formats.txt to rst On Wed, Dec 06, 2017 at 04:39:58PM -0800, Randy Dunlap wrote: > On 12/06/2017 01:16 PM, Tobin C. Harding wrote: > > On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote: > > > > Thanks for your comments Randy. > > > > >>> Documentation/index.rst | 10 + > >>> .../{printk-formats.txt => printk-formats.rst} | 295 ++++++++++++--------- > >>> lib/vsprintf.c | 160 +++++------ > >>> 3 files changed, 235 insertions(+), 230 deletions(-) > >>> rename Documentation/{printk-formats.txt => printk-formats.rst} (61%) > >> > >>> diff --git a/Documentation/printk-formats.txt b/Documentation/printk-formats.rst > >>> similarity index 61% > >>> rename from Documentation/printk-formats.txt > >>> rename to Documentation/printk-formats.rst > >>> index aa0a776c817a..51449d213748 100644 > >>> --- a/Documentation/printk-formats.txt > >>> +++ b/Documentation/printk-formats.rst > > >>> @@ -194,8 +233,8 @@ printing SSIDs. > >>> > >>> If field width is omitted the 1 byte only will be escaped. > >> > >> then > >> I think... > > > > Ha ha, I was borderline with this change when doing this patch. It may > > not appear so but I did try to do the minimal amount of changes while > > improving correctness. I appreciate your comments since hopefully I can > > better make these judgment calls next time. > > I wasn't so sure about that attempt (at minimal changes). :) ROFL > > Will change as suggested. > > >>> Where no additional specifiers are used the default big endian > >>> -order with lower case hex characters will be printed. > >>> +order with lower case hex digits will be printed. > >> > >> digits could imply base 10. but no big deal. > > > > Are you sure about this? I was under the impression that when > > representing a number the character set used are refereed to as 'digits' > > irrespective of base. > > > > hexadecimal digit > > octal digit > > digit (assumed base 10) > > > > Open to correction though. > > Like I said, I don't care strongly about this. (I'm easy.) > but hex notation (like you said later) sounds good. Got it. thanks, Tobin.
Powered by blists - more mailing lists