linux-kernel - Re: [PATCH 2/2] acpi, x86: Use SPCR table for earlycon on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Dec 2017 12:46:40 -0600
From:   Timur Tabi <timur@...eaurora.org>
To:     Prarit Bhargava <prarit@...hat.com>
Cc:     ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        linux-pm@...r.kernel.org,
        Catalin Marinas <catalin.marinas@....com>,
        Bhupesh Sharma <bhsharma@...hat.com>,
        linux-doc@...r.kernel.org, Will Deacon <will.deacon@....com>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Lv Zheng <lv.zheng@...el.com>, linux-serial@...r.kernel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>
Subject: Re: [PATCH 2/2] acpi, x86: Use SPCR table for earlycon on x86

On Thu, Dec 7, 2017 at 11:29 AM, Prarit Bhargava <prarit@...hat.com> wrote:
> -int __init acpi_parse_spcr(bool earlycon)
> +int __init acpi_parse_spcr(bool earlycon, bool enable_console)
>  {
>         static char opts[ACPI_SPCR_OPTS_SIZE];
>         static char uart[ACPI_SPCR_BUF_SIZE];
> @@ -113,7 +113,8 @@ int __init acpi_parse_spcr(bool earlycon)
>         if (earlycon)
>                 setup_earlycon(opts);
>
> -       err = add_preferred_console(uart, 0, opts + strlen(uart) + 1);
> +       if (enable_console)
> +               err = add_preferred_console(uart, 0, opts + strlen(uart) + 1);

So if earlycon==true but enable_console==false, then you parse SPCR
and use it for the early console, but not the primary console?  I'm
not sure what that gives you.