linux-kernel - Re: [PATCH] mux: add SPDX identifiers to all mux source files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 08 Dec 2017 10:43:46 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Peter Rosin <peda@...ntia.se>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mux: add SPDX identifiers to all mux source files

Hi Peter,

On Thu, 2017-12-07 at 22:08 +0100, Peter Rosin wrote:
> Remove all free-text license texts.
> 
> This is done on a quest to remove the 700+ different ways that files in
> the kernel describe the GPL license text.
> 
> No copyright headers or other non-license-description text was removed.
> 
> Signed-off-by: Peter Rosin <peda@...ntia.se>
> ---
> 
> Hi Philipp,
> 
> I assume this is ok with you for the mmio file, but asking just in case...
[...]
> diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c
> index 37c1de359a70..935ac44aa209 100644
> --- a/drivers/mux/mmio.c
> +++ b/drivers/mux/mmio.c
> @@ -1,11 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0

Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

>  /*
>   * MMIO register bitfield-controlled multiplexer driver
>   *
>   * Copyright (C) 2017 Pengutronix, Philipp Zabel <kernel@...gutronix.de>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
>   */
>  
>  #include <linux/bitops.h>
> diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h
> index ea96d4c82be7..5fc6bb2fefad 100644
> --- a/include/linux/mux/consumer.h
> +++ b/include/linux/mux/consumer.h
> @@ -1,13 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Is there a system to the different comment styles in c the files vs in
the headers?

regards
Philipp