linux-kernel - Re: [PATCH 5/9] pnp: remove unneeded kallsyms include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hQ+QyJZ_bw9AGaSByvckpK5MeU=jkuy-MYg4Qdzoxrrw@mail.gmail.com>
Date:   Fri, 8 Dec 2017 15:02:22 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        Rafael Wysocki <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Fengguang Wu <fengguang.wu@...el.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Petr Mladek <pmladek@...e.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux PCI <linux-pci@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH 5/9] pnp: remove unneeded kallsyms include

On Fri, Dec 8, 2017 at 3:56 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@...il.com> wrote:
> The file was converted from print_fn_descriptor_symbol()
> to %pF some time ago (2e532d68a2b3e2aa {pci,pnp} quirks.c:
> don't use deprecated print_fn_descriptor_symbol()). kallsyms
> does not seem to be needed anymore.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> ---
>  drivers/pnp/quirks.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
> index f054cdddfef8..803666ae3635 100644
> --- a/drivers/pnp/quirks.c
> +++ b/drivers/pnp/quirks.c
> @@ -21,7 +21,6 @@
>  #include <linux/slab.h>
>  #include <linux/pnp.h>
>  #include <linux/io.h>
> -#include <linux/kallsyms.h>
>  #include "base.h"
>
>  static void quirk_awe32_add_ports(struct pnp_dev *dev,
> --

Do you want me to apply this or do you want to route it differently?