linux-kernel - Re: [PATCH 4/9] pci: remove unneeded kallsyms include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Dec 2017 11:53:45 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        Rafael Wysocki <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Fengguang Wu <fengguang.wu@...el.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Petr Mladek <pmladek@...e.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-pm@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-mm@...ck.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH 4/9] pci: remove unneeded kallsyms include

On Fri, Dec 08, 2017 at 11:56:11AM +0900, Sergey Senozhatsky wrote:
> The file was converted from print_fn_descriptor_symbol()
> to %pF some time ago (c9bbb4abb658da "PCI: use %pF instead
> of print_fn_descriptor_symbol() in quirks.c"). kallsyms does
> not seem to be needed anymore.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>

Applied to pci/misc for v4.16, thanks for cleaning this up!

I *assume* there's no ordering dependency like the one you mentioned
for sched/printk.  If there is, let me know, and I'll move this to
for-linus to get it in v4.15.

> ---
>  drivers/pci/quirks.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 10684b17d0bd..fd49b976973f 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -19,7 +19,6 @@
>  #include <linux/init.h>
>  #include <linux/delay.h>
>  #include <linux/acpi.h>
> -#include <linux/kallsyms.h>
>  #include <linux/dmi.h>
>  #include <linux/pci-aspm.h>
>  #include <linux/ioport.h>
> -- 
> 2.15.1
>