lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Dec 2017 13:08:11 +0100 From: Philippe Ombredanne <pombredanne@...b.com> To: Finn Thain <fthain@...egraphics.com.au> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, linux-m68k@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: Re: [PATCH v3 14/14] nubus: Add support for the driver model Finn, On Sun, Dec 10, 2017 at 11:03 AM, Finn Thain <fthain@...egraphics.com.au> wrote: > On Thu, 7 Dec 2017, Philippe Ombredanne wrote: > >> > diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c >> > new file mode 100644 >> > index 000000000000..b5045e639b4d >> > --- /dev/null >> > +++ b/drivers/nubus/bus.c >> > @@ -0,0 +1,119 @@ >> > +/* >> > + * Bus implementation for the NuBus subsystem. >> > + * >> > + * Copyright (C) 2017 Finn Thain >> > + * >> > + * SPDX-License-Identifier: GPL-2.0 >> > + */ >> >> I think the SPDX id should be on the first line using C++-style // comments. > > Sure, why not. > > Since Linus has explicitly allowed conversion of the entire block comment > to C++ style, I think I may prefer that as being less ugly than the > mixture of styles (though fwiw this will always read like top posting to > me). > >> See tglx's doc patches > > I didn't find any mention of SPDX under Documentation... > >> and Linus posts explaining why he wants it this way! >> > > I suspect that you are referring to his posts in this thread (?) > https://lkml.org/lkml/2017/11/2/728 Actually this is patch series: https://lkml.org/lkml/2017/12/4/934 And possibly some minor fixes pending, based on Heiko eagle eye review and some of my nits. -- Cordially Philippe Ombredanne +1 650 799 0949 | pombredanne@...B.com DejaCode - What's in your code?! - http://www.dejacode.com AboutCode - Open source for open source - https://www.aboutcode.org nexB Inc. - http://www.nexb.com
Powered by blists - more mailing lists