linux-kernel - [PATCH] tty: isicom: Delete an error message for a failed memory allocation in load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 10 Dec 2017 17:07:03 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     kernel-janitors@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] tty: isicom: Delete an error message for a failed memory
 allocation in load_firmware()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sun, 10 Dec 2017 17:00:05 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/tty/isicom.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c
index ee7958ab269f..c087ebfe62fd 100644
--- a/drivers/tty/isicom.c
+++ b/drivers/tty/isicom.c
@@ -1482,11 +1482,9 @@ static int load_firmware(struct pci_dev *pdev,
 		}
 
 		data = kmalloc(word_count * 2, GFP_KERNEL);
-		if (data == NULL) {
-			dev_err(&pdev->dev, "Card%d, firmware upload "
-				"failed, not enough memory\n", index + 1);
+		if (!data)
 			goto errrelfw;
-		}
+
 		inw(base);
 		insw(base, data, word_count);
 		InterruptTheCard(base);
-- 
2.15.1