linux-kernel - Re: [PATCH] KVM: introduce kvm_arch_vcpu_async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Dec 2017 18:47:11 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     kvm-ppc@...r.kernel.org, cohuck@...hat.com,
        christoffer.dall@...aro.org, James Hogan <jhogan@...nel.org>,
        Paul Mackerras <paulus@...abs.org>,
        Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH] KVM: introduce kvm_arch_vcpu_async_ioctl


>  
>  	switch (ioctl) {
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index ba8134a989c1..2e700753e35c 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -1607,12 +1607,11 @@ int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu,
>  	return -EINVAL;
>  }
>  
> -long kvm_arch_vcpu_ioctl(struct file *filp,
> -                         unsigned int ioctl, unsigned long arg)
> +long kvm_arch_vcpu_async_ioctl(struct file *filp,
> +      			       unsigned int ioctl, unsigned long arg)

are you mixing spaces and tabs?

>  {
>  	struct kvm_vcpu *vcpu = filp->private_data;
>  	void __user *argp = (void __user *)arg;
> -	long r;
>  
>  	if (ioctl == KVM_INTERRUPT) {
>  		struct kvm_interrupt irq;
> @@ -1620,6 +1619,15 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
>  			return -EFAULT;
>  		return kvm_vcpu_ioctl_interrupt(vcpu, &irq);
>  	}
> +	return -ENOIOCTLCMD;
> +}
> +
> +long kvm_arch_vcpu_ioctl(struct file *filp,
> +                         unsigned int ioctl, unsigned long arg)

dito

> +{
> +	struct kvm_vcpu *vcpu = filp->private_data;
> +	void __user *argp = (void __user *)arg;
> +	long r;
>  
>  	vcpu_load(vcpu);
>  
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 9700d71cb691..40f0ae5a883f 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -3725,13 +3725,11 @@ static long kvm_s390_guest_mem_op(struct kvm_vcpu *vcpu,
>  	return r;
>  }
>  
> -long kvm_arch_vcpu_ioctl(struct file *filp,
> -			 unsigned int ioctl, unsigned long arg)
> +long kvm_arch_vcpu_async_ioctl(struct file *filp,
> +			       unsigned int ioctl, unsigned long arg)
>  {
>  	struct kvm_vcpu *vcpu = filp->private_data;
>  	void __user *argp = (void __user *)arg;
> -	int idx;
> -	long r;
>  
>  	switch (ioctl) {
>  	case KVM_S390_IRQ: {
> @@ -3752,6 +3750,16 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
>  		return kvm_s390_inject_vcpu(vcpu, &s390irq);
>  	}
>  	}
> +	return -ENOIOCTLCMD;
> +}
> +
> +long kvm_arch_vcpu_ioctl(struct file *filp,
> +			 unsigned int ioctl, unsigned long arg)
> +{
> +	struct kvm_vcpu *vcpu = filp->private_data;
> +	void __user *argp = (void __user *)arg;
> +	int idx;
> +	long r;
>  
>  	vcpu_load(vcpu);
>  
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 09de0ff3d677..a900d20a5320 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -736,6 +736,8 @@ long kvm_arch_dev_ioctl(struct file *filp,
>  			unsigned int ioctl, unsigned long arg);
>  long kvm_arch_vcpu_ioctl(struct file *filp,
>  			 unsigned int ioctl, unsigned long arg);
> +long kvm_arch_vcpu_async_ioctl(struct file *filp,
> +			       unsigned int ioctl, unsigned long arg);
>  int kvm_arch_vcpu_fault(struct kvm_vcpu *vcpu, struct vm_fault *vmf);
>  
>  int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext);
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 19c184fa1839..262d6c910fe7 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -2547,13 +2547,13 @@ static long kvm_vcpu_ioctl(struct file *filp,
>  #if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS)

can we now also get rid of this ugly define?

>  	/*
>  	 * Special cases: vcpu ioctls that are asynchronous to vcpu execution,
> -	 * so vcpu_load() would break it.
> +	 * so mutex_lock() would break it.
>  	 */
> -	if (ioctl == KVM_S390_INTERRUPT || ioctl == KVM_S390_IRQ || ioctl == KVM_INTERRUPT)
> -		return kvm_arch_vcpu_ioctl(filp, ioctl, arg);
> +	r = kvm_arch_vcpu_async_ioctl(filp, ioctl, arg);
> +	if (r != -ENOIOCTLCMD)
> +		return r;
>  #endif
>  
> -

unrelated change but the right thing to do :)

>  	if (mutex_lock_killable(&vcpu->mutex))
>  		return -EINTR;
>  	switch (ioctl) {
> 

Looks good to me!

-- 

Thanks,

David / dhildenb