[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 12 Dec 2017 13:34:00 +0000
From: Mark Rutland <mark.rutland@....com>
To: Cornelia Huck <cohuck@...hat.com>
Cc: linux-kernel@...r.kernel.org,
"Michael S . Tsirkin" <mst@...hat.com>,
weiping zhang <zhangweiping@...ichuxing.com>,
virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] virtio_mmio: fix devm cleanup
On Tue, Dec 12, 2017 at 02:31:48PM +0100, Cornelia Huck wrote:
> On Tue, 12 Dec 2017 13:29:02 +0000
> Mark Rutland <mark.rutland@....com> wrote:
>
> > On Tue, Dec 12, 2017 at 02:09:52PM +0100, Cornelia Huck wrote:
>
> > > Shouldn't the cleanup in _remove() then be removed as well?
> >
> > Ah, I'd missed that.
> >
> > I believe that can be removed, yes.
> >
> > Should I spin a v2 with that folded in?
>
> I think it has the same devm_ioremap vs. iounmap discrepancy, so it
> should probably be folded in.
Ah, yes. I'll spin a v2 now.
Thanks,
Mark.
Powered by blists - more mailing lists