linux-kernel - Re: [PATCH v2 05/11] ASoC: fsl_ssi: Refine indentations and wrappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 14:33:57 -0800
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:     broonie@...nel.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, alsa-devel@...a-project.org,
        lgirdwood@...il.com, fabio.estevam@....com, timur@...i.org,
        caleb@...me.org, arnaud.mouiche@...oxia.com, lukma@...x.de,
        kernel@...gutronix.de
Subject: Re: [PATCH v2 05/11] ASoC: fsl_ssi: Refine indentations and wrappings

On Wed, Dec 13, 2017 at 11:30:31PM +0100, Maciej S. Szmigiero wrote:
> On 13.12.2017 07:34, Nicolin Chen wrote:
> > This patch just simply unifies the coding style.
> > 
> > Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> > ---
> > 
> > Changelog
> > v1->v2
> >  * Added two missing indentation changes
> >  * Removed two extra blank lines.
> > 
> >  sound/soc/fsl/fsl_ssi.c     | 239 +++++++++++++++++++++-----------------------
> >  sound/soc/fsl/fsl_ssi.h     |   2 +-
> >  sound/soc/fsl/fsl_ssi_dbg.c |   3 +-
> >  3 files changed, 118 insertions(+), 126 deletions(-)
> > 
> > diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> > index 8b5407d..9a3db08 100644
> > --- a/sound/soc/fsl/fsl_ssi.c
> > +++ b/sound/soc/fsl/fsl_ssi.c
> (..)
> > @@ -916,12 +917,11 @@ static int _fsl_ssi_set_dai_fmt(struct device *dev,
> >  	case SND_SOC_DAIFMT_DSP_A:
> >  		/* Data on rising edge of bclk, frame high, 1clk before data */
> >  		strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP |
> > -			SSI_STCR_TXBIT0 | SSI_STCR_TEFS;
> > +			 SSI_STCR_TXBIT0 | SSI_STCR_TEFS;
> >  		break;
> >  	case SND_SOC_DAIFMT_DSP_B:
> >  		/* Data on rising edge of bclk, frame high */
> > -		strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP |
> > -			SSI_STCR_TXBIT0;
> > +		strcr |= SSI_STCR_TFSL | SSI_STCR_TSCKP |  SSI_STCR_TXBIT0;
> 
> It looks like an extra space got here			 ^.

Good catch.

Thanks