linux-kernel - Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 13:49:49 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     Takashi <tiwai@...e.de>, LKML <linux-kernel@...r.kernel.org>,
        ALSA <alsa-devel@...a-project.org>, Mark <broonie@...nel.org>,
        Pierre <pierre-louis.bossart@...ux.intel.com>,
        patches.audio@...el.com, alan@...ux.intel.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sagar Dharia <sdharia@...eaurora.org>,
        srinivas.kandagatla@...aro.org, plai@...eaurora.org,
        Sudheer Papothi <spapothi@...eaurora.org>
Subject: Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

On Thu, Dec 14, 2017 at 04:23:20PM +0530, Vinod Koul wrote:
> On Thu, Dec 14, 2017 at 08:35:08AM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Dec 14, 2017 at 11:19:31AM +0530, Vinod Koul wrote:
> > > Changes in v6:
> > >   - Add reviewed/acked tags from Philippe, Pierre, Takashi and Greg
> > >   - Fix nitpicks from Takashi
> > >   - Drop the sysfs patch for now
> > 
> > Wait, why drop the sysfs patch entirely?  You need those attributes,
> > right?  You also need to document the existing sysfs files in
> > Documentation/ABI/ for the class/device files you create in this patch
> > series, so that needs to be done before this patch series can be
> > accepted.
> 
> Well the sysfs patch is a standalone patch which contains the attributes. So
> I dropped that "for this series" and plan to submit after reworking.
> 
> The rest of the code doesn't depend on it, so is fine.
> 
> I thought it is an okay kernel practice to drop patches with issues, merge the
> rest and come back after fixing the issue. This is my plan for this as well.

Ok, but that feels a bit rushed, as I'm guessing those sysfs files are
essencial for the use of the hardware.  To not include them feels odd to
me :)

Anyway, what about the basic ABI documentation for the sysfs files you
have in this series?  You need to have that patch in this series,
otherwise it is really hard to get people to do it after the fact.

thanks,

gre k-h