linux-kernel - Re: [PATCH v2] rtc: Add tracepoints for RTC system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Dec 2017 11:07:54 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Mark Brown <broonie@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, linux-rtc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] rtc: Add tracepoints for RTC system

On 13 December 2017 at 20:23, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> On 13/12/2017 at 12:16:03 +0000, Mark Brown wrote:
>> On Wed, Dec 13, 2017 at 12:04:26PM +0100, Alexandre Belloni wrote:
>>
>> > Also, I think we could try having only the time64_t in the ring buffer.
>> > Maybe I'm wrong but I think tools reading that buffer can do the
>> > conversion themselves. Maybe I don't understand correctly how
>> > tracepoints work and this doesn't make sense, tell me.
>>
>> Tools reading the buffer can do the conversion themselves but it's also
>> useful for users to just view the log directly via tracing/trace
>> sometimes.  OTOH the whole point is to be low overhead so...
>
> Yes, that is why I suggest keeping both representation in the printk
> but only time64_t in the buffer. And this would be more convenient if we
> add a way to pretty print a time64_t in vsprintf.

OK. I will only keep time64_t in the buffer. Thanks for all your comments.

-- 
Baolin.wang
Best Regards