linux-kernel - Re: [PATCH][V2] mtd: sharpslpart: fix overflow on block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Dec 2017 17:27:05 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Andrea Adami <andrea.adami@...il.com>
Cc:     Colin King <colin.king@...onical.com>,
        Richard Weinberger <richard@....at>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH][V2] mtd: sharpslpart: fix overflow on block_adr
 calculation

On Fri, 10 Nov 2017 17:35:13 +0100
Andrea Adami <andrea.adami@...il.com> wrote:

> On Wed, Nov 8, 2017 at 5:13 PM, Colin King <colin.king@...onical.com> wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> >
> > Multiplying block_num and mtd->erasesize may potentially overflow
> > as they are both unsigned ints and so the multiplication is evaluated
> > in unsigned int arithmetic.  Cast block_adr to off_t to ensure
> > multiplication is off_t sized to avoid any potential overflow.
> >
> > Detected by CoverityScan, CID#1461264 ("Unintentional integer overflow")
> >
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  drivers/mtd/parsers/sharpslpart.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> > index 5fe0079ea5ed..0ddb79ac390d 100644
> > --- a/drivers/mtd/parsers/sharpslpart.c
> > +++ b/drivers/mtd/parsers/sharpslpart.c
> > @@ -192,7 +192,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
> >
> >         /* create physical-logical table */
> >         for (block_num = 0; block_num < phymax; block_num++) {
> > -               block_adr = block_num * mtd->erasesize;
> > +               block_adr = (loff_t)block_num * mtd->erasesize;
> >
> >                 if (mtd_block_isbad(mtd, block_adr))
> >                         continue;
> > @@ -244,7 +244,7 @@ static int sharpsl_nand_read_laddr(struct mtd_info *mtd,
> >                 return -EINVAL;
> >
> >         block_num = ftl->log2phy[log_num];
> > -       block_adr = block_num * mtd->erasesize;
> > +       block_adr = (loff_t)block_num * mtd->erasesize;
> >         block_ofs = mtd_mod_by_eb((u32)from, mtd);
> >
> >         err = mtd_read(mtd, block_adr + block_ofs, len, &retlen, buf);
> > --
> > 2.14.1
> >  
> 
> Thanks for spotting this,
> 
> Acked-by: Andrea Adami <andrea.adami@...il.com>

Applied.

Thanks,

Boris