linux-kernel - [PATCH] input/touchscreen: fix hideep.c build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 17 Dec 2017 17:09:52 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kbuild test robot <fengguang.wu@...el.com>,
        Anthony Kim <anthony.kim@...eep.com>
Subject: [PATCH] input/touchscreen: fix hideep.c build errors

From: Randy Dunlap <rdunlap@...radead.org>

Fix build errors due to missing header file.

Fixes these build errors:
drivers/input//touchscreen/hideep.c: In function 'hideep_power_on':
drivers/input//touchscreen/hideep.c:670:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration]
    gpiod_set_value_cansleep(ts->reset_gpio, 0);
drivers/input//touchscreen/hideep.c: In function 'hideep_power_off':
drivers/input//touchscreen/hideep.c:688:3: error: implicit declaration of function 'gpiod_set_value'; did you mean 'gpio_set_value'? [-Werror=implicit-function-declaration]
    gpiod_set_value(ts->reset_gpio, 1);
drivers/input//touchscreen/hideep.c: In function 'hideep_probe':
drivers/input//touchscreen/hideep.c:1039:19: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
   ts->reset_gpio = devm_gpiod_get_optional(&client->dev,
drivers/input//touchscreen/hideep.c:1040:17: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function); did you mean 'GPIOF_INIT_HIGH'?
         "reset", GPIOD_OUT_HIGH);

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Reported-by: kbuild test robot <fengguang.wu@...el.com>
Cc: Anthony Kim <anthony.kim@...eep.com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org
---
 drivers/input/touchscreen/hideep.c |    1 +
 1 file changed, 1 insertion(+)

--- lnx-415-rc3.orig/drivers/input/touchscreen/hideep.c
+++ lnx-415-rc3/drivers/input/touchscreen/hideep.c
@@ -11,6 +11,7 @@
 #include <linux/firmware.h>
 #include <linux/delay.h>
 #include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/gpio/machine.h>
 #include <linux/i2c.h>
 #include <linux/acpi.h>