linux-kernel - Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Dec 2017 10:37:10 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Cathy Avery <cavery@...hat.com>
Cc:     kys@...rosoft.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, sthemmin@...rosoft.com,
        linux-scsi@...r.kernel.org, haiyangz@...rosoft.com,
        linux-kernel@...r.kernel.org, devel@...uxdriverproject.org
Subject: Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in
 storvsc_handle_error

On Tue, 19 Dec 2017 13:32:48 -0500
Cathy Avery <cavery@...hat.com> wrote:

> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise
> the I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait forever for its I/O to complete while holding scsi_sd_probe_domain.
> 
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
> 
> Signed-off-by: Cathy Avery <cavery@...hat.com>
> Signed-off-by: Long Li <longli@...rosoft.com>

When working on the DVD probe issue I saw that error handling was
problematic. Thanks for fixing.

Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>