linux-kernel - Re: [PATCH v2 4/5] dt-bindings: at24: extend the list of supported chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Dec 2017 16:12:00 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Javier Martinez Canillas <javier@...hile0.org>,
        David Lechner <david@...hnology.com>,
        Divagar Mohandass <divagar.mohandass@...el.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] dt-bindings: at24: extend the list of supported chips

On Thu, Dec 21, 2017 at 3:48 PM, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> Add other variants of at24 EEPROMs we support in the driver to the
> list of allowed compatible strings.

>          "atmel,24c00",
>          "atmel,24c01",
> +        "atmel,24cs01",
>          "atmel,24c02",
> +        "atmel,24cs02",
> +        "atmel,24mac402",
> +        "atmel,24mac602",
>          "atmel,spd",
>          "atmel,24c04",
> +        "atmel,24cs04",
>          "atmel,24c08",
> +        "atmel,24cs08",
>          "atmel,24c16",
> +        "atmel,24cs16",
>          "atmel,24c32",

Same comments as per spd case.

For me more naturally to have them grouped by letters inside, i.e.
          "atmel,24c00",
          "atmel,24c01",
...
        "atmel,24cs01",
        "atmel,24cs02",
...
       "atmel,24mac402",
       "atmel,24mac602",

-- 
With Best Regards,
Andy Shevchenko