linux-kernel - Re: [PATCH 06/11] ARM: davinci: constify gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Dec 2017 15:31:52 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, <khilman@...nel.org>,
        <linux@...linux.org.uk>, <kaloz@...nwrt.org>, <khalasa@...p.pl>,
        <aaro.koskinen@....fi>, <tony@...mide.com>, <jason@...edaemon.net>,
        <andrew@...n.ch>, <sebastian.hesselbarth@...il.com>,
        <gregory.clement@...e-electrons.com>, <daniel@...que.org>,
        <haojian.zhuang@...il.com>, <robert.jarzmik@...e.fr>,
        <marek.vasut@...il.com>, <slapin@...fans.org>, <jic23@....ac.uk>,
        <kgene@...nel.org>, <krzk@...nel.org>, <ralf@...ux-mips.org>,
        <ysato@...rs.sourceforge.jp>, <dalias@...c.org>,
        <tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/11] ARM: davinci: constify gpio_led

On Wednesday 20 December 2017 02:17 PM, Arvind Yadav wrote:
> gpio_led are not supposed to change at runtime.
> struct gpio_led_platform_data working with const gpio_led
> provided by <linux/leds.h>. So mark the non-const structs
> as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

This causes a new section mismatch warning

WARNING: vmlinux.o(.data+0x16d7c): Section mismatch in reference from the variable ntosd2_leds_data to the (unknown reference) .init.rodata:(unknown)
The variable ntosd2_leds_data references
the (unknown reference) __initconst (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console


Thanks,
Sekhar