linux-kernel - Re: [PATCH 00/11] constify gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Dec 2017 10:13:21 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     nsekhar@...com, khilman@...nel.org, kaloz@...nwrt.org,
        khalasa@...p.pl, aaro.koskinen@....fi, tony@...mide.com,
        jason@...edaemon.net, andrew@...n.ch,
        sebastian.hesselbarth@...il.com,
        gregory.clement@...e-electrons.com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        marek.vasut@...il.com, slapin@...fans.org, jic23@....ac.uk,
        kgene@...nel.org, krzk@...nel.org, ralf@...ux-mips.org,
        ysato@...rs.sourceforge.jp, dalias@...c.org, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/11] constify gpio_led

On Wed, Dec 20, 2017 at 02:17:41PM +0530, Arvind Yadav wrote:
> gpio_led are not supposed to change at runtime.
> struct gpio_led_platform_data working with const gpio_led
> provided by <linux/leds.h>. So mark the non-const structs
> as const.

Marking the structs as const is fine, but marking them __initconst is
not.  The GPIO LED driver can be built as a module, which means it can
be loaded after the init sections have gone away.  If that happens,
then we de-reference the pointer to memory that has been freed.

Please re-spin your patch set without the __initconst marking.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up