linux-kernel - Re: [regression] Re: Thinkpad T40p: suspend to ram stopped working sometime before 4.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Dec 2017 23:37:40 +0100
From:   Pavel Machek <pavel@....cz>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        gregkh@...uxfoundation.org, kyle@...nel.org,
        akpm@...ux-foundation.org, mmarek@...e.com,
        yamada.masahiro@...ionext.com, dwmw2@...radead.org,
        markus@...ppelsdorf.de, torvalds@...ux-foundation.org
Cc:     kernel list <linux-kernel@...r.kernel.org>, len.brown@...el.com,
        linux-pm@...r.kernel.org
Subject: Re: [regression] Re: Thinkpad T40p: suspend to ram stopped working
 sometime before 4.14

Hi!

> > > > > 4.15-rcX is broken, but that had other problems so lets not go there.
> > > > > 
> > > > > 4.14 is broken.
> > > > 
> > > > And what exactly does happen?
> > > 
> > > Suspend looks ok. I believe there's some reaction to power button, but
> > > screen stays blank. I'll re-check that.. I'm in the middle of bisect
> > > now.
> > 
> > Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> > bluetooth LEDs go on, but screen is black and no response to
> > > > > anything.
> 
> And it seems bad commit is
> 
> commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> Author: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Date:   Thu Sep 14 14:23:01 2017 -0700
> 
>     firmware: delete in-kernel firmware
> 
> Unfortuantely, it does not revert cleanly.

I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
top of it, partialy reverting it. Seems like 5620 was causing problems
for other people before.

And then there's huge mega-patch called "license cleanup" on top of
that, which changes 11100 files (!) and makes work harder still.

Can we go for full revert?

Changelog 

"""    The last firmware change for the in-kernel firmware source code
was back
    in 2013.  Everyone has been relying on the out-of-tree
    linux-firmware
    package for a long long time."""

does not really explain what is going on there, and I'd certainly not
expect silent breakage of suspend/resume. Clearly 5620a0 patch did not
get nearly enough testing.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)