linux-kernel - Re: [PATCH v2] clk: mediatek: Fix all warnings for missing struct clk_onecell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Dec 2017 17:16:06 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     sean.wang@...iatek.com
Cc:     mturquette@...libre.com, matthias.bgg@...il.com,
        linux-mediatek@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, kbuild-all@...org,
        Jean Delvare <jdelvare@...e.de>
Subject: Re: [PATCH v2] clk: mediatek: Fix all warnings for missing struct
 clk_onecell_data

On 12/25, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> Even though the header file linux/clk-provider.h is already being properly
> included in clk-mtk.h, the definition of struct clk_onecell_data still
> must depend on CONFIG_COMMON_CLK defined and thus it's possible that
> below build warnings occur when CONFIG_COMMON_CLK is not being selected.
> 
> Therefore, these functions which need struct clk_onecell_data without
> declaring that structure first requires simply declaring that this struct
> exists prior to referencing it in clk-mtk.h
> 
> Changes from v1->v2:
> enhance v1 based on two useful solutions Jean Delvare kindly suggested.
> 
> All warnings (new ones prefixed by >>):
> 
> In file included from drivers/clk/mediatek/reset.c:22:0:
> >>drivers/clk/mediatek/clk-mtk.h:44:19: warning: 'struct clk_onecell_data'
> declared inside parameter list will not be visible outside of
> this definition or declaration
>   int num, struct clk_onecell_data *clk_data);
> 		  ^~~~~~~~~~~~~~~~
> drivers/clk/mediatek/clk-mtk.h:63:19: warning: 'struct clk_onecell_data'
> declared inside parameter list will not be visible outside of
> this definition or declaration
>   int num, struct clk_onecell_data *clk_data);
> 		  ^~~~~~~~~~~~~~~~
> drivers/clk/mediatek/clk-mtk.h:145:10: warning: 'struct clk_onecell_data'
> declared inside parameter list will not be visible outside of
> this definition or declaration
>   struct clk_onecell_data *clk_data);
> 	 ^~~~~~~~~~~~~~~~
> drivers/clk/mediatek/clk-mtk.h:164:11: warning: 'struct clk_onecell_data'
> declared inside parameter list will not be visible outside of
> this definition or declaration
>    struct clk_onecell_data *clk_data);
> 	  ^~~~~~~~~~~~~~~~
> drivers/clk/mediatek/clk-mtk.h:190:12: warning: 'struct clk_onecell_data'
> declared inside parameter list will not be visible outside of this
> definition or declaration
>     struct clk_onecell_data *clk_data);
> 	   ^~~~~~~~~~~~~~~~
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> Cc: kbuild-all@...org
> Cc: Stephen Boyd <sboyd@...eaurora.org>
> Cc: Jean Delvare <jdelvare@...e.de>
> Cc: linux-clk@...r.kernel.org
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project