linux-kernel - Re: [PATCH v5 1/2] fs: fat: Add fat filesystem partition volume label in local structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Dec 2017 22:21:11 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     ChenGuanqiao <chen.chenchacha@...mail.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] fs: fat: Add fat filesystem partition volume label in local structure

ChenGuanqiao <chen.chenchacha@...mail.com> writes:

> +static int fat_get_volume_label_entry(struct inode *dir, loff_t *pos,
> +			       struct buffer_head **bh,
> +			       struct msdos_dir_entry **de)
> +{
> +	while (fat_get_entry(dir, pos, bh, de) >= 0)
> +		if (((*de)->attr & ATTR_VOLUME) && (*de)->attr != ATTR_EXT)
> +			return 0;
> +	return -ENOENT;
> +}
> +
> +int fat_scan_volume_label(struct inode *dir, struct fat_slot_info *sinfo)
> +{
> +	struct super_block *sb = dir->i_sb;
> +
> +	sinfo->slot_off = 0;
> +	sinfo->bh = NULL;
> +	while (fat_get_volume_label_entry(dir, &sinfo->slot_off,
> +					  &sinfo->bh, &sinfo->de) >= 0) {
> +		sinfo->slot_off -= sizeof(*sinfo->de);
> +		sinfo->nr_slots = 1;
> +		sinfo->i_pos = fat_make_i_pos(sb, sinfo->bh, sinfo->de);
> +
> +		return 0;
> +	}
> +
> +	return -ENOENT;
> +}
> +EXPORT_SYMBOL_GPL(fat_scan_volume_label);

Why do you need sinfo?
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>