linux-kernel - Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Dec 2017 22:51:02 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Łukasz Stelmach <l.stelmach@...sung.com>
Cc:     "Andrew F . Davis" <afd@...com>,
        PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, linux-crypto@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

Łukasz,

On Wed, Dec 27, 2017 at 11:12 AM, Łukasz Stelmach
<l.stelmach@...sung.com> wrote:
> It was <2017-12-22 pią 19:30>, when Philippe Ombredanne wrote:
>> On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach <l.stelmach@...sung.com> wrote:
>>> It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote:
>>>> Łukasz,
>>>>
>>>> On Fri, Dec 22, 2017 at 2:23 PM, Łukasz Stelmach <l.stelmach@...sung.com> wrote:
>>>>> Add support for True Random Number Generator found in Samsung Exynos
>>>>> 5250+ SoCs.
>>>>>
>>>>> Signed-off-by: Łukasz Stelmach <l.stelmach@...sung.com>
>>>>> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
>>>>
>>>> <snip>
>>>>
>>>>> --- /dev/null
>>>>> +++ b/drivers/char/hw_random/exynos-trng.c
>>>>> @@ -0,0 +1,245 @@
>>>>> +/*
>>>>> + * RNG driver for Exynos TRNGs
>>>>> + *
>>>>> + * Author: Łukasz Stelmach <l.stelmach@...sung.com>
>>>>> + *
>>>>> + * Copyright 2017 (c) Samsung Electronics Software, Inc.
>>>>> + *
>>>>> + * Based on the Exynos PRNG driver drivers/crypto/exynos-rng by
>>>>> + * Krzysztof Kozłowski <krzk@...nel.org>
>>>>> + *
>>>>> + * This program is free software; you can redistribute it and/or modify
>>>>> + * it under the terms of the GNU General Public License as published by
>>>>> + * the Free Software Foundation;
>>>>> + *
>>>>> + * This program is distributed in the hope that it will be useful,
>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>>> + * GNU General Public License for more details.
>>>>> + */
>>>>
>>>>
>>>> Would you mind using the new SPDX tags documented in Thomas patch set
>>>> [1] rather than this fine but longer legalese?
>>>>
>>>> And if you could spread the word to others in your team this would be very nice.
>>>> See also this fine article posted by Mauro on the Samsung Open Source
>>>> Group Blog [2]
>>>> Thank you!
>>>
>>> Cool! We've been using SPDX to tag RPM packages in Tizen for three years or
>>> more. ;-)
>>
>> Very nice! any pubic pointers?
>                  ^^^^^
>
> I assume you request an URL of a publicly available web-page ;-)
>
> https://wiki.tizen.org/Packaging/Guidelines#License_Tag

Thank you!
I reckon it took me a minute to figure why you were making a somewhat
cryptic URL related comment.
Then I realized that I had made a rather unfortunate typo, or may be
it was a freudian slip of sorts :D

-- 
Cordially
Philippe Ombredanne