linux-kernel - Re: [PATCH] tee: shm: make function __tee_shm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Dec 2017 22:19:22 +0100
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tee: shm: make function __tee_shm_alloc static

On Fri, Dec 22, 2017 at 6:01 PM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The function __tee_shm_alloc is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol '__tee_shm_alloc' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/tee/tee_shm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
> index 04e1b8b37046..13b4de1157c7 100644
> --- a/drivers/tee/tee_shm.c
> +++ b/drivers/tee/tee_shm.c
> @@ -112,9 +112,9 @@ static const struct dma_buf_ops tee_shm_dma_buf_ops = {
>         .mmap = tee_shm_op_mmap,
>  };
>
> -struct tee_shm *__tee_shm_alloc(struct tee_context *ctx,
> -                               struct tee_device *teedev,
> -                               size_t size, u32 flags)
> +static struct tee_shm *__tee_shm_alloc(struct tee_context *ctx,
> +                                      struct tee_device *teedev,
> +                                      size_t size, u32 flags)
>  {
>         struct tee_shm_pool_mgr *poolm = NULL;
>         struct tee_shm *shm;
> --
> 2.14.1
>

Looks good. Thanks.

/Jens