linux-kernel - Re: WARNING in strp_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Dec 2017 08:54:45 +0100
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Tom Herbert <tom@...bertland.com>
Cc:     Ozgur <ozgur@...sey.org>,
        John Fastabend <john.fastabend@...il.com>,
        syzbot 
        <bot+c91c53af67f9ebe599a337d2e70950366153b295@...kaller.appspotmail.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Biggers <ebiggers@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com>,
        Tom Herbert <tom@...ntonium.net>,
        Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: WARNING in strp_data_ready

On Thu, Dec 28, 2017 at 2:19 AM, Tom Herbert <tom@...bertland.com> wrote:
> On Wed, Dec 27, 2017 at 12:20 PM, Ozgur <ozgur@...sey.org> wrote:
>>
>>
>> 27.12.2017, 23:14, "Dmitry Vyukov" <dvyukov@...gle.com>:
>>> On Wed, Dec 27, 2017 at 9:08 PM, Ozgur <ozgur@...sey.org> wrote:
>>>>  27.12.2017, 22:21, "Dmitry Vyukov" <dvyukov@...gle.com>:
>>>>>  On Wed, Dec 27, 2017 at 8:09 PM, Tom Herbert <tom@...bertland.com> wrote:
>>>>>>   Did you try the patch I posted?
>>>>>
>>>>>  Hi Tom,
>>>>
>>>>  Hello Dmitry,
>>>>
>>>>>  No. And I didn't know I need to. Why?
>>>>>  If you think the patch needs additional testing, you can ask syzbot to
>>>>>  test it. See https://github.com/google/syzkaller/blob/master/docs/syzbot.md#communication-with-syzbot
>>>>>  Otherwise proceed with committing it. Or what are we waiting for?
>>>>>
>>>>>  Thanks
>>>>
>>>>  I think we need to fixed patch for crash, in fact check to patch code and test solve the bug.
>>>>  How do test it because there is no patch in the following bug?
>>>
>>> Hi Ozgur,
>>>
>>> I am not sure I completely understand what you mean. But the
>>> reproducer for this bug (which one can use for testing) is here:
>>> https://groups.google.com/forum/#!topic/syzkaller-bugs/Kxs05ziCpgY
>>> Tom also mentions there is some patch for this, but I don't know where
>>> it is, it doesn't seem to be referenced from this thread.
>>
>> Hello Dmitry,
>>
>> Ah, I'm sorry I don't seen Tom mail and I don't have a patch not tested :)
>> I think Tom send patch to only you and are you tested?
>>
>> kcmsock.c will change and strp_data_ready I think locked.
>>
>> Tom, please send a patch for me? I can test and inform you.
>>
> Hi Ozgur,
>
> I reposted the patches as RFC "kcm: Fix lockdep issue". Please test if you can!

OK, I will work as your typist this time:

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master

But I wonder what part of the following you don't understand? Do we
need to improve wording or something?

> If you think the patch needs additional testing, you can ask syzbot to test it.
> See https://github.com/google/syzkaller/blob/master/docs/syzbot.md#communication-with-syzbot

Also I don't know what git repo/branch you have in mind. Kernel
patches don't generally apply just to any tree. Fingers crossed that I
guessed correctly and it will apply.

View attachment "strparser.patch" of type "text/x-patch" (999 bytes)