linux-kernel - Re: [PATCH] uuid: cleanup <uapi/linux/uuid.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 Dec 2017 18:39:26 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexey Dobriyan <adobriyan@...il.com>,
        Christoph Hellwig <hch@...radead.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] uuid: cleanup <uapi/linux/uuid.h>

On Mon, Dec 25, 2017 at 7:11 PM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> Exported header doesn't use anything from <linux/string.h>,
> it is <linux/uuid.h> which uses memcmp().
>

+Cc UUID maintainer(s)

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

(If I didn't miss anything, that looks fine)

> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
>
>  include/linux/uuid.h      |    1 +
>  include/uapi/linux/uuid.h |    1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
>
> --- a/include/linux/uuid.h
> +++ b/include/linux/uuid.h
> @@ -17,6 +17,7 @@
>  #define _LINUX_UUID_H_
>
>  #include <uapi/linux/uuid.h>
> +#include <linux/string.h>
>
>  #define UUID_SIZE 16
>
> --- a/include/uapi/linux/uuid.h
> +++ b/include/uapi/linux/uuid.h
> @@ -19,7 +19,6 @@
>  #define _UAPI_LINUX_UUID_H_
>
>  #include <linux/types.h>
> -#include <linux/string.h>
>
>  typedef struct {
>         __u8 b[16];



-- 
With Best Regards,
Andy Shevchenko